| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, "pgsql-hackers\(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: INT64_MIN and _MAX |
| Date: | 2015-03-24 21:57:42 |
| Message-ID: | 87619q6ouh.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Kevin" == Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
>> I didn't replace the 0xFFFFFFFF ones because most or all of them
>> looked like basically bit-masking operations rather than actually
>> dealing with the bounds of an unsigned int or uint32. I was
>> specifically looking for places where literals were being used to
>> represent maximum or minimum values.
Kevin> Well, InvalidSerCommitSeqNo was initially defined to be
Kevin> UINT64_MAX -- but some buildfarm members didn't know about that
Kevin> so it was changed to UINT64CONST(0xFFFFFFFFFFFFFFFF). It is
Kevin> very much about wanting the maximum value for uint64.
That one _is_ changed to UINT64_MAX in my patch.
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-03-24 22:29:11 | Re: parallel mode and parallel contexts |
| Previous Message | Andrew Gierth | 2015-03-24 21:55:47 | Re: Exposing PG_VERSION_NUM in pg_config |