Re: INT64_MIN and _MAX

Hello,

Grep showed me some unfixed usages of bare constant or INT64CONST
as (u)int64 max/min values.

At Tue, 24 Mar 2015 21:57:42 +0000, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote in <87619q6ouh(dot)fsf(at)news-spur(dot)riddles(dot)org(dot)uk>
> >>>>> "Kevin" == Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
> Kevin> Well, InvalidSerCommitSeqNo was initially defined to be
> Kevin> UINT64_MAX -- but some buildfarm members didn't know about that
> Kevin> so it was changed to UINT64CONST(0xFFFFFFFFFFFFFFFF). It is
> Kevin> very much about wanting the maximum value for uint64.
>
> That one _is_ changed to UINT64_MAX in my patch.

./src/interfaces/ecpg/pgtypeslib/dt.h:
> #define DT_NOBEGIN (-INT64CONST(0x7fffffffffffffff) - 1)
> #define DT_NOEND (INT64CONST(0x7fffffffffffffff))

./contrib/pgcrypto/imath.h:
> #define MP_WORD_MAX 0xFFFFFFFFFFFFFFFFULL

Likewise, bare (u)int32/16 min/max's are found as following.

./contrib/pgcrypto/imath.h:
> #define MP_DIGIT_MAX 0xFFFFFFFFULL
..
> #define MP_DIGIT_MAX 0xFFFFUL
> #define MP_WORD_MAX 0xFFFFFFFFUL

# MP_DIGIT_MAX was wrong in word length. They are in the half
# length of MP_WORD_MAX.

./src/backend/utils/mb/wchar.c
./src/bin/psql/mbprint.c:
> return 0xffffffff;

Additional fixes for the above are in the patch attached.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center