| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Logical replication support for initial data copy |
| Date: | 2017-03-23 14:25:14 |
| Message-ID: | 8573bded-a414-b184-93cd-5952800ce3f8@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 23/03/17 15:17, Stephen Frost wrote:
> Petr,
>
> * Petr Jelinek (petr(dot)jelinek(at)2ndquadrant(dot)com) wrote:
>> On 23/03/17 14:47, Petr Jelinek wrote:
>>> I am looking into buildfarm failures.
>>>
>>> Looks like the clang issue (mylodon, longfin) is because we are missing
>>> extern in include/replication/worker_internal.h for ApplyCacheContext.
>>>
>>> Still analyzing the rest.
>>
>> Ah missing fields in copy/equal function for AlterSubscriptionStmt.
>>
>> Attached patch adds the above mentioned extern and fixes the copy and
>> equal functions.
>
> Pretty sure I saw a complaint about a trailing comma in a struct or enum
> too..
>
Ah, missed that in the wall of text, thanks, fixed that too.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| logical-replication-copy-patch-fixesv2.patch | text/x-patch | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-03-23 15:30:35 | pgsql: Minor spelling correction in comment |
| Previous Message | Stephen Frost | 2017-03-23 14:17:35 | Re: pgsql: Logical replication support for initial data copy |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maksim Milyutin | 2017-03-23 14:27:14 | Re: Partitioned tables and relfilenode |
| Previous Message | Stas Kelvich | 2017-03-23 14:24:03 | Re: GSOC'17 project introduction: Parallel COPY execution with errors handling |