| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Logical replication support for initial data copy |
| Date: | 2017-03-23 14:17:35 |
| Message-ID: | 20170323141735.GS9812@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Petr,
* Petr Jelinek (petr(dot)jelinek(at)2ndquadrant(dot)com) wrote:
> On 23/03/17 14:47, Petr Jelinek wrote:
> > I am looking into buildfarm failures.
> >
> > Looks like the clang issue (mylodon, longfin) is because we are missing
> > extern in include/replication/worker_internal.h for ApplyCacheContext.
> >
> > Still analyzing the rest.
>
> Ah missing fields in copy/equal function for AlterSubscriptionStmt.
>
> Attached patch adds the above mentioned extern and fixes the copy and
> equal functions.
Pretty sure I saw a complaint about a trailing comma in a struct or enum
too..
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-03-23 14:25:14 | Re: pgsql: Logical replication support for initial data copy |
| Previous Message | Petr Jelinek | 2017-03-23 14:12:13 | Re: pgsql: Logical replication support for initial data copy |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-03-23 14:23:27 | Re: Patch: Write Amplification Reduction Method (WARM) |
| Previous Message | Petr Jelinek | 2017-03-23 14:12:13 | Re: pgsql: Logical replication support for initial data copy |