| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data |
| Date: | 2021-07-27 12:50:55 |
| Message-ID: | 845C714B-DBCF-49E9-9F95-238DB042F926@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> 24 июля 2021 г., в 03:30, Noah Misch <noah(at)leadboat(dot)com> написал(а):
>
> It could be okay, but I think it's better to add the test under amcheck. You
> could still use pgbench in the test.
Currently it's still WIP.
I've added two tests: deterministic with psql and probabilistic with pgbench.
And I really do not like pgbench test:
1. It does not seem stable enough, it can turn buildfarm red as a good watermelon.
2. Names for 2PCs are choosen at random and have probability of collision.
3. It still breaks the fix and I have no idea why.
Can you please take a look on added TAP test? Probably I'm doing wrong a lot of things, it's the very first program on Perl written by me...
background_pgbench is a local invention. sub pgbench is a copy from nearby test. Should I refactor it somewhere?
Thanks!
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Introduce-TAP-test-for-2PC-with-CIC-behavior.patch | application/octet-stream | 7.0 KB |
| v5-0002-Fix-CREATE-INDEX-CONCURRENTLY-in-precence-of-vxid.patch | application/octet-stream | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2021-07-27 14:39:41 | BUG #17124: Psql prompting for a password |
| Previous Message | Daniel Gustafsson | 2021-07-27 11:58:19 | Re: Postgresql12: ERROR: Could not read from file "pg_act/02 F 4" at offset 253952: read too few bytes |