Re: Allow tests to pass in OpenSSL FIPS mode

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allow tests to pass in OpenSSL FIPS mode
Date: 2023-03-08 09:26:54
Message-ID: 84550e37-c3e6-94a5-538f-063f6dcacf08@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08.03.23 08:40, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> On 05.03.23 00:04, Tom Lane wrote:
>>> I've gone through this and have a modest suggestion: let's invent some
>>> wrapper functions around encode(sha256()) to reduce the cosmetic diffs
>>> and consequent need for closer study of patch changes. In the attached
>>> I called them "notmd5()", but I'm surely not wedded to that name.
>
>> Do you mean create this on the fly in the test suite, or make it a new
>> built-in function?
>
> The former --- please read my version of the patch.

Ok, that makes sense. We have some other uses of this pattern in other
test suites that my initial patch didn't cover yet, for example in
src/test/subscripton, but we don't have expected files there, so the
argument of reducing the diffs doesn't apply.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-03-08 09:28:00 Re: Allow tests to pass in OpenSSL FIPS mode
Previous Message Daniel Gustafsson 2023-03-08 09:21:26 Re: Allow tests to pass in OpenSSL FIPS mode