| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, xinwen(at)stu(dot)scu(dot)edu(dot)cn, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17777: An assert failed in nodeWindowAgg.c |
| Date: | 2023-02-12 16:19:41 |
| Message-ID: | 842393.1676218781@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Sat, 11 Feb 2023 at 13:49, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> I think we could just add a !contain_subplans() to the code deciding whether
>> it's safe to use the movable window optimization?
> I think this is a fair way to fix the bug.
Agreed.
> Here's a patch for that.
Why is it okay to check only the filter, and not the rest of the
WindowFunc's subexpressions? The arguments we've just run through
seem to apply to a subplan in the direct or aggregated arguments
as well.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-02-12 17:53:39 | Re: BUG #17788: Incorrect memory access when parsing empty string as sql_standard interval |
| Previous Message | David Rowley | 2023-02-12 10:30:25 | Re: BUG #17777: An assert failed in nodeWindowAgg.c |