Re: pg_combinebackup --clone doesn't work

On 8/23/24 14:50, Tomas Vondra wrote:
>
> On 8/23/24 14:00, Peter Eisentraut wrote:
>> On 30.06.24 20:58, Tomas Vondra wrote:
>>> I've pushed the first three patches, fixing the headers, adding the
>>> --copy option and PG_TEST_PG_COMBINEBACKUP_MODE variable.
>>>
>>> I haven't pushed the CI changes, I'm not sure if there's a clear
>>> consensus on which combination to test. It's something we can tweak
>>> later, I think.
>>>
>>> FWIW I've added the patch to the 2024-07 commitfest, but mostly to get
>>> some CI runs (runs on private fork fail with some macos issues unrelated
>>> to the patch).
>>
>> This last patch is still pending in the commitfest.  Personally, I think
>> it's good to commit as is.
>>
>
> OK, thanks for reminding me. I'll take care of it after thinking about
> it a bit more.
>

Took me longer than I expected, but pushed (into master only).

regards

--
Tomas Vondra