Re: pgsql: Test replay of regression tests, attempt II.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <tmunro(at)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Test replay of regression tests, attempt II.
Date: 2022-01-17 17:24:48
Message-ID: 8373.1642440288@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> I'm quite appalled that this patch has apparently added an entire new run
> of the core regression tests to the standard check-world/buildfarm cycle.

Not only that, but it leaves junk that is neither cleaned by "make clean"
nor .gitignored:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
(use "git add <file>..." to include in what will be committed)
primary.dump
results/
standby.dump

$ make clean
rm -rf tmp_check

These files should have been put into the tmp_check directory...
that's what it's for.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2022-01-17 17:42:35 Re: pgsql: Test replay of regression tests, attempt II.
Previous Message Tom Lane 2022-01-17 15:25:21 Re: pgsql: Test replay of regression tests, attempt II.