Re: BUG #17485: Records missing from Primary Key index when doing REINDEX INDEX CONCURRENTLY

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Петър Славов <pet(dot)slavov(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #17485: Records missing from Primary Key index when doing REINDEX INDEX CONCURRENTLY
Date: 2022-05-26 05:16:09
Message-ID: 833BC7FF-4CA5-482C-B08E-7F65440EB64C@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 26 May 2022, at 08:39, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, May 25, 2022 at 11:17:33PM -0400, Bruce Momjian wrote:
>> * Caused by CREATE/REINDEX CONCURRENTLY
>
> Yes.
>
>> * No way to detect which indexes were created concurrently
>> * amcheck will be required to find corrupt indexes (options?)
>
> amcheck would help for btree, not the other AMs. I am not sure but
> there could be other symptoms that may not be detected by amcheck?

Noah invented a neat way to do check in pre-heapallindexed versions [0]. I think we can make GiST and some others AMs be checked this way.

BTW, patches for GiST and GIN verification are circulating in pgsql-hackers. Would anyone be interested in reviewing? If so - I'll add heapallindexed to GiST verification.
Last GIN version by Heikki was in a good condition, though without heapallindexed AFAIK. [1] [2]

Best regards, Andrey Borodin.

[0] https://github.com/postgres/postgres/blob/REL_11_STABLE/src/bin/pgbench/t/022_cic.pl#L28-L40
[1] https://www.postgresql.org/message-id/flat/a5bc2aad-464b-91bd-061d-28af0f9b634c%40iki.fi#222ef3f6cbdd6f86172b38ff7663e6a3
[2] https://www.postgresql.org/message-id/CAF3eApa07-BajjG8%2BRYx-Dr_cq28ZA0GsZmUQrGu5b2ayRhB5A%40mail.gmail.com

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Петър Славов 2022-05-26 05:29:11 Re: BUG #17485: Records missing from Primary Key index when doing REINDEX INDEX CONCURRENTLY
Previous Message Richard Guo 2022-05-26 04:34:04 Re: BUG #17495: Regression in 15beta1 when filtering subquery including row_number window function