| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeremy Finzel <finzelj(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Docs for refresh materialized view concurrently |
| Date: | 2019-06-01 17:30:59 |
| Message-ID: | 82568.1559410259@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeremy Finzel <finzelj(at)gmail(dot)com> writes:
> I've not submitted a patch before, and have a few suggestions I'd like
> feedback on before I write one (for the docs only).
OK ...
> First, even this summary looks untrue:
> REFRESH MATERIALIZED VIEW — replace the contents of a materialized view.
Agreed. I'd just make it say "update the contents...", personally.
More words are not better in command summaries.
> Also, the Description part has the same inaccuracy:
> "completely replaces the contents of a materialized view.....The old
> contents are discarded."
Yeah, that just wasn't updated :-(
> On a different note, none of the documentation on materialized views notes
> that they can only be LOGGED. This should be noted,
Also agreed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-06-01 19:09:24 | Custom table AMs need to include heapam.h because of BulkInsertState |
| Previous Message | Tom Lane | 2019-06-01 17:23:05 | Re: coverage increase for worker_spi |