Re: pgsql: Modify interactions between sinval.c and sinvaladt.c.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Modify interactions between sinval.c and sinvaladt.c.
Date: 2008-03-17 00:17:12
Message-ID: 8178.1205713032@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> Modify interactions between sinval.c and sinvaladt.c. The code that actually
> deals with the queue, including locking etc, is all in sinvaladt.c. This means
> that the struct definition of the queue, and the queue pointer, are now
> internal "implementation details" inside sinvaladt.c.

This looks good, but I wonder why you didn't move struct ProcState
into sinvaladt.c as well?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-03-17 01:46:42 pgsql: Done: > o -During index creation, pre-sort the tuples to
Previous Message Tom Lane 2008-03-16 23:57:51 pgsql: Add a note to the CREATE INDEX reference page about the impact of