| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Modify interactions between sinval.c and sinvaladt.c. |
| Date: | 2008-03-17 11:51:04 |
| Message-ID: | 20080317115104.GA6083@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Tom Lane wrote:
> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> > Modify interactions between sinval.c and sinvaladt.c. The code that actually
> > deals with the queue, including locking etc, is all in sinvaladt.c. This means
> > that the struct definition of the queue, and the queue pointer, are now
> > internal "implementation details" inside sinvaladt.c.
>
> This looks good, but I wonder why you didn't move struct ProcState
> into sinvaladt.c as well?
I didn't notice that, thanks. Done.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-03-17 13:34:16 | Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom. |
| Previous Message | Alvaro Herrera | 2008-03-17 11:50:27 | pgsql: Move ProcState definition into sinvaladt.c from sinvaladt.h, |