Re: pgsql: Remove deprecated abstime, reltime, tinterval datatypes.

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove deprecated abstime, reltime, tinterval datatypes.
Date: 2018-10-11 20:54:41
Message-ID: 81685d0e-ed37-428a-2c39-362c524824e1@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 10/11/2018 03:02 PM, Andres Freund wrote:
> Remove deprecated abstime, reltime, tinterval datatypes.
>
> These types have been deprecated for a *long* time.

This has broken pg_upgrade from previous versions:

pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 212; 1259 16891
TABLE abstime_tbl buildfarm
pg_restore: [archiver (db)] could not execute query: ERROR:  type
"abstime" does not exist
LINE 14:     "f1" "abstime"
                  ^
    Command was:
-- For binary upgrade, must preserve pg_type oid
SELECT
pg_catalog.binary_upgrade_set_next_pg_type_oid('16893'::pg_catalog.oid);

-- For binary upgrade, must preserve pg_type array oid
SELECT
pg_catalog.binary_upgrade_set_next_array_pg_type_oid('16892'::pg_catalog.oid);

-- For binary upgrade, must preserve pg_class oids
SELECT
pg_catalog.binary_upgrade_set_next_heap_pg_class_oid('16891'::pg_catalog.oid);

CREATE TABLE "public"."abstime_tbl" (
    "f1" "abstime"
);

-- For binary upgrade, set heap's relfrozenxid and relminmxid
UPDATE pg_catalog.pg_class
SET relfrozenxid = '2643', relminmxid = '1'
WHERE oid = '"public"."abstime_tbl"'::pg_catalog.regclass;

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-10-11 20:57:44 Re: pgsql: Remove deprecated abstime, reltime, tinterval datatypes.
Previous Message Andres Freund 2018-10-11 19:02:53 pgsql: Move timeofday() implementation out of nabstime.c.