Re: pgsql: Remove deprecated abstime, reltime, tinterval datatypes.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove deprecated abstime, reltime, tinterval datatypes.
Date: 2018-10-11 20:57:44
Message-ID: 20181011205744.lpmveiwjdxe24q34@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2018-10-11 16:54:41 -0400, Andrew Dunstan wrote:
>
>
> On 10/11/2018 03:02 PM, Andres Freund wrote:
> > Remove deprecated abstime, reltime, tinterval datatypes.
> >
> > These types have been deprecated for a *long* time.
>
>
> This has broken pg_upgrade from previous versions:
>
> pg_restore: [archiver (db)] Error while PROCESSING TOC:
> pg_restore: [archiver (db)] Error from TOC entry 212; 1259 16891
> TABLE abstime_tbl buildfarm
> pg_restore: [archiver (db)] could not execute query: ERROR:  type
> "abstime" does not exist
> LINE 14:     "f1" "abstime"
>                   ^
>     Command was:
> -- For binary upgrade, must preserve pg_type oid
> SELECT
> pg_catalog.binary_upgrade_set_next_pg_type_oid('16893'::pg_catalog.oid);

I'm not sure I see the problem you're seeing here? You've an abstime
column. That type has been removed. So you get an error? Or is your
concern solely that it affects automated testing?

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-10-12 00:17:57 pgsql: Add TAP tests for pg_verify_checksums
Previous Message Andrew Dunstan 2018-10-11 20:54:41 Re: pgsql: Remove deprecated abstime, reltime, tinterval datatypes.