On 30/07/2024 22:31, Jeff Davis wrote:
> I noticed this comment in selfuncs.c regarding strxfrm():
>
> /*
> * Some systems (e.g., glibc) can return a smaller value from the
> * second call than the first; thus the Assert must be <= not ==.
> */
>
> Some callers of pg_strnxfrm() are not allowing for that possibility.
>
> Patch attached, which should be backported to 17.
+1. A comment in the pg_strnxfrm() function itself would be good too.
--
Heikki Linnakangas
Neon (https://neon.tech)