Re: meson vs windows perl

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Muralikrishna Bandaru <muralikrishna(dot)bandaru(at)enterprisedb(dot)com>, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>
Subject: Re: meson vs windows perl
Date: 2024-07-30 19:47:16
Message-ID: 0f106f21-764a-4d82-a704-b2727079feb7@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2024-07-20 Sa 9:41 AM, Andrew Dunstan wrote:
>
> On 2024-05-28 Tu 6:13 PM, Andres Freund wrote:
>> Hi,
>>
>> On 2024-04-05 16:12:12 -0400, Andrew Dunstan wrote:
>>> OK, this has been fixed and checked. The attached is what I propose.
>> The perl command is pretty hard to read. What about using python's shlex
>> module instead? Rough draft attached.  Still not very pretty, but
>> seems easier
>> to read?
>>
>> It'd be even better if we could just get perl to print out the flags
>> in an
>> easier to parse way, but I couldn't immediately see a way.
>>
>>
>
> Thanks for looking.
>
> The attached should be easier to read. The perl package similar to
> shlex is Text::ParseWords, which is already a requirement.

It turns out that shellwords eats backslashes, so we would need
something like this version, which I have tested on Windows. I will
probably commit this in the next few days unless there's an objection.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
ldopts5.patch text/x-patch 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-07-30 20:01:00 Re: [17+] check after second call to pg_strnxfrm is too strict, relax it
Previous Message Peter Eisentraut 2024-07-30 19:46:47 Re: Support LIKE with nondeterministic collations