| From: | 邱宇航 <iamqyh(at)gmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Transaction timeout |
| Date: | 2023-12-07 10:39:55 |
| Message-ID: | 81204476-219E-4725-AA26-6C6DC3A3A6DC@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I read the V6 patch and found something needs to be improved.
Prepared transactions should also be documented.
A value of zero (the default) disables the timeout.
+ This timeout is not applied to prepared transactions. Only transactions
+ with user connections are affected.
Missing 'time'.
- gettext_noop("Sets the maximum allowed in a transaction."),
+ gettext_noop("Sets the maximum allowed time in a transaction."),
16 is already released. It's 17 now.
- if (AH->remoteVersion >= 160000)
+ if (AH->remoteVersion >= 170000)
ExecuteSqlStatement(AH, "SET transaction_timeout = 0");
And I test the V6 patch and it works as expected.
--
Yuhang Qiu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-12-07 10:51:53 | Re: remaining sql/json patches |
| Previous Message | jian he | 2023-12-07 10:39:03 | Re: remaining sql/json patches |