| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remaining sql/json patches |
| Date: | 2023-12-07 10:51:53 |
| Message-ID: | 202312071051.cpxujwos4tlj@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-Dec-07, Erik Rijkers wrote:
> Hm, this set doesn't apply for me. 0003 gives error, see below (sorrty for
> my interspersed bash echoing - seemed best to leave it in.
> (I'm using patch; should be all right, no? Am I doing it wrong?)
There's definitely something wrong with the patch file; that binary file
should not be there. OTOH clearly if we ever start including binary
files in our tree, `patch` is no longer going to cut it. Maybe we won't
ever do that, though.
There's also a complaint about whitespace.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"El destino baraja y nosotros jugamos" (A. Schopenhauer)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2023-12-07 11:04:37 | Removing const-false IS NULL quals and redundant IS NOT NULL quals |
| Previous Message | 邱宇航 | 2023-12-07 10:39:55 | Re: Transaction timeout |