| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | houzj(dot)fnst(at)cn(dot)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Use PG_FINALLY to simplify code |
| Date: | 2020-09-30 03:10:52 |
| Message-ID: | 806487.1601435452@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
> At Tue, 29 Sep 2020 01:03:13 +0000, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote in
>> Since PG_FINALLY can be used now, I think we can use PG_FINALLY to simplify code here.
> The patch removes PG_RETHROW(), which is crucial in the code
> path.
No, that's not a problem, because PG_FINALLY incorporates logic
to reproduce the PG_RE_THROW action if we get to the code block
due to an error being thrown.
The patch is nonetheless moot, because after a6b1f5365 those
two code paths are no longer identical.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | osumi.takamichi@fujitsu.com | 2020-09-30 03:10:53 | RE: Disable WAL logging to speed up data loading |
| Previous Message | Tom Lane | 2020-09-30 02:58:56 | Re: NOTIFY docs fixup - emit and deliver consistency |