Re: Use PG_FINALLY to simplify code

At Tue, 29 Sep 2020 23:10:52 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
tgl> Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
tgl> > At Tue, 29 Sep 2020 01:03:13 +0000, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote in
tgl> >> Since PG_FINALLY can be used now, I think we can use PG_FINALLY to simplify code here.
tgl>
tgl> > The patch removes PG_RETHROW(), which is crucial in the code
tgl> > path.
tgl>
tgl> No, that's not a problem, because PG_FINALLY incorporates logic
tgl> to reproduce the PG_RE_THROW action if we get to the code block
tgl> due to an error being thrown.

Oops! Sorry. It's exactly the definition of finally block.

tgl> The patch is nonetheless moot, because after a6b1f5365 those
tgl> two code paths are no longer identical.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center