From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Only provide new libpq sslpasskey hook for openssl-enabled build |
Date: | 2020-04-17 19:46:47 |
Message-ID: | 802aad18-cab1-a98b-879e-2c111d23efb4@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 4/17/20 3:27 PM, Daniel Gustafsson wrote:
>> On 17 Apr 2020, at 20:19, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>
>> Only provide new libpq sslpasskey hook for openssl-enabled builds
>>
>> In commit 4dc6355210 I neglected to put #ifdef USE_OPENSSL around the
>> declarations of the new items. This is remedied here.
> This wasn't really the problem I reported though. As per my patch [0] in the
> email, the issue is with openssl_tls_init_hook in src/include/libpq/libpq-be.h
> requiring an OpenSSL specific SSL_CTX parameter, thus breaking compilation for
> other TLS backends. The name also makes it somewhat backend specific =)
>
> PQgetSSLKeyPassHook is written generic enough that it could make sense for
> other backends too, but for now I think we can keep the guards introduced in
> this commit.
>
> cheers ./daniel
>
Oh, *sigh* brainfade.
Will fix.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2020-04-17 20:00:04 | pgsql: Only provide openssl_tls_init_hook if building with openssl |
Previous Message | Daniel Gustafsson | 2020-04-17 19:27:53 | Re: pgsql: Only provide new libpq sslpasskey hook for openssl-enabled build |