| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Only provide new libpq sslpasskey hook for openssl-enabled build |
| Date: | 2020-04-17 19:27:53 |
| Message-ID: | 34E10ADF-C350-481E-91EB-7548F1EDA722@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
> On 17 Apr 2020, at 20:19, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> Only provide new libpq sslpasskey hook for openssl-enabled builds
>
> In commit 4dc6355210 I neglected to put #ifdef USE_OPENSSL around the
> declarations of the new items. This is remedied here.
This wasn't really the problem I reported though. As per my patch [0] in the
email, the issue is with openssl_tls_init_hook in src/include/libpq/libpq-be.h
requiring an OpenSSL specific SSL_CTX parameter, thus breaking compilation for
other TLS backends. The name also makes it somewhat backend specific =)
PQgetSSLKeyPassHook is written generic enough that it could make sense for
other backends too, but for now I think we can keep the guards introduced in
this commit.
cheers ./daniel
[0] E1BB5261-5C89-494A-841B-283DAD27A2EA(at)yesql(dot)se
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2020-04-17 19:46:47 | Re: pgsql: Only provide new libpq sslpasskey hook for openssl-enabled build |
| Previous Message | Andrew Dunstan | 2020-04-17 18:59:02 | pgsql: Use a slightly more liberal regex to detect Visual Studio versio |