| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christophe Pettus <christophe(dot)pettus(at)pgexperts(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: BUG #14825: enum type: unsafe use? |
| Date: | 2017-09-25 18:17:09 |
| Message-ID: | 7ca5214d-f981-54e4-c65a-470a87aa665e@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 09/25/2017 01:34 PM, David E. Wheeler wrote:
> On Sep 25, 2017, at 10:55, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>
>> Let's ask a couple of users who I think are or have been actually
>> hurting on this point. Christophe and David, any opinions?
> If I understand the issue correctly, I think I’d be fine with requiring ALTER TYPE ADD LABEL to be disallowed in a transaction that also CREATEs the type if it’s not currently possible to reliably tell when an enum was created in a transaction. Once you can do that, then by all means allow it!
>
OK, that seems to be the consensus. So let's apply the blacklist patch
and then separately remove the 'created in the same transaction' test.
We'll need to adjust the regression tests and docs accordingly.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sebastian Gröbler | 2017-09-25 18:19:45 | Segmentation fault mayhem |
| Previous Message | Дилян Палаузов | 2017-09-25 18:10:57 | Re: Query planner skipping index depending on DISTINCT parameter order (2) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Hernandez | 2017-09-25 18:20:00 | Re: Built-in plugin for logical decoding output |
| Previous Message | Fabien COELHO | 2017-09-25 18:10:17 | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |