Re: pgsql: Add support for collation attributes on older ICU versions

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add support for collation attributes on older ICU versions
Date: 2019-03-19 08:49:14
Message-ID: 7c37a038-c132-dde9-1a39-5132c628075e@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-03-18 20:03, Andres Freund wrote:
> I now get this warning:
>
> /home/andres/src/postgresql/src/backend/utils/adt/pg_locale.c:1680:14: warning: comparison of constant -1 with expression of type 'UColAttribute' is always true [-Wtautological-constant-out-of-range-compare]
> if (uattr != -1 && uvalue != -1)
> ~~~~~ ^ ~~

I found a bug in that code and restructured it a bit. It should also
avoid this warning now.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-03-19 09:28:46 pgsql: Fix whitespace
Previous Message Peter Eisentraut 2019-03-19 08:48:09 pgsql: Fix bug in support for collation attributes on older ICU version