Re: pgsql: Add support for collation attributes on older ICU versions

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add support for collation attributes on older ICU versions
Date: 2019-03-19 15:32:04
Message-ID: 20190319153204.ske4achkx7zsok5u@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-03-19 09:49:14 +0100, Peter Eisentraut wrote:
> On 2019-03-18 20:03, Andres Freund wrote:
> > I now get this warning:
> >
> > /home/andres/src/postgresql/src/backend/utils/adt/pg_locale.c:1680:14: warning: comparison of constant -1 with expression of type 'UColAttribute' is always true [-Wtautological-constant-out-of-range-compare]
> > if (uattr != -1 && uvalue != -1)
> > ~~~~~ ^ ~~
>
> I found a bug in that code and restructured it a bit. It should also
> avoid this warning now.

Thanks.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-03-19 16:49:48 pgsql: Make checkpoint requests more robust.
Previous Message Alvaro Herrera 2019-03-19 14:09:25 Re: pgsql: Revise parse tree representation for VACUUM and ANALYZE.