| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typo in pg_db_role_setting.h |
| Date: | 2022-08-02 07:45:36 |
| Message-ID: | 7E9E61EF-F028-4976-81AE-CA0E3697452B@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 2 Aug 2022, at 09:37, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> The examples listed upthread all contain such comment in foo.h saying
> 'prototypes for functions in foo.c'. For instance, in buffile.h, there is
> comment saying
> /*
> * prototypes for functions in buffile.c
> */
>
> So if we remove such comments, should we also do so for those cases?
Comments which state the obvious are seldom helpful, I would prefer to remove
such comments and only explicitly call out the .c file in a comment when it's a
different basename from the header.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2022-08-02 07:58:40 | Re: Typo in pg_db_role_setting.h |
| Previous Message | Kyotaro Horiguchi | 2022-08-02 07:44:23 | Re: Strange behavior with polygon and NaN |