From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql-server/src backend/commands/variable.c b ... |
Date: | 2003-05-22 18:12:00 |
Message-ID: | 794.1053627120@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Maybe on your machine we need to include <sys/time.h> or some such?
> I just checked using grep on all my /usr/include files, and can't find
> tzname anywhere, but it is in libc. I added a line to port/bsdi.h to
> fix it, but I am not sure that is the correct solution.
I looked at the autoconf macro that tests for existence of tzname[],
and saw that it explicitly does
#ifndef tzname /* For SGI. */
extern char *tzname[];
#endif
after including <time.h>. So it seems that they are expecting some
systems not to provide a declaration for tzname even though they have it.
I have checked in a fix that does #ifdef HAVE_TZNAME, and includes
a declaration as above. (Without the declaration, we would fail anyway
on machines that are like this.) So you shouldn't need the port/bsdi.h
hack anymore.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-05-22 18:31:53 | pgsql-server/doc/src/sgml release.sgml |
Previous Message | Peter Eisentraut - PostgreSQL | 2003-05-22 17:20:44 | pgsql-server/src include/port/cygwin.h include ... |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-05-22 19:07:27 | Re: [COMMITTERS] pgsql-server/src backend/commands/variable.c b ... |
Previous Message | Tom Lane | 2003-05-22 17:44:15 | Re: Is postgres 7.2.1 safe if there is a power fail. |