Re: [COMMITTERS] pgsql-server/src backend/commands/variable.c b ...

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src backend/commands/variable.c b ...
Date: 2003-05-22 19:07:27
Message-ID: 200305221907.h4MJ7Rt19735@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


OK, thanks.

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> Maybe on your machine we need to include <sys/time.h> or some such?
>
> > I just checked using grep on all my /usr/include files, and can't find
> > tzname anywhere, but it is in libc. I added a line to port/bsdi.h to
> > fix it, but I am not sure that is the correct solution.
>
> I looked at the autoconf macro that tests for existence of tzname[],
> and saw that it explicitly does
>
> #ifndef tzname /* For SGI. */
> extern char *tzname[];
> #endif
>
> after including <time.h>. So it seems that they are expecting some
> systems not to provide a declaration for tzname even though they have it.
>
> I have checked in a fix that does #ifdef HAVE_TZNAME, and includes
> a declaration as above. (Without the declaration, we would fail anyway
> on machines that are like this.) So you shouldn't need the port/bsdi.h
> hack anymore.
>
> regards, tom lane
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian - CVS 2003-05-22 19:14:27 pgsql-server/src/include/port bsdi.h
Previous Message Tom Lane 2003-05-22 18:32:02 pgsql-server/doc/src/sgml Tag: REL7_3_STABLE r ...

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-05-22 19:12:37 Missing EAI_ADDRFAMILY
Previous Message Tom Lane 2003-05-22 18:12:00 Re: [COMMITTERS] pgsql-server/src backend/commands/variable.c b ...