Re: pgsql: Add missing installcheck target to pg_rewind's Makefile

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: pgsql: Add missing installcheck target to pg_rewind's Makefile
Date: 2015-04-21 20:38:29
Message-ID: 7864.1429648709@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
> Add missing installcheck target to pg_rewind's Makefile

This patch seems a brick shy of a load, in that "make installcheck" in
bin/pg_rewind leaves behind a bunch of junk in a tmp_check/ subdirectory.
installcheck in any other src/bin/ subdirectory doesn't do that.

(I chanced to notice this while wondering why hamster is failing on
this test. I can't reproduce the failure locally, but ...)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-04-21 21:50:16 pgsql: Update FDW docs to reflect existence of CHECK constraints.
Previous Message Heikki Linnakangas 2015-04-21 11:10:43 pgsql: Add missing installcheck target to pg_rewind's Makefile