| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: pgsql: Add missing installcheck target to pg_rewind's Makefile |
| Date: | 2015-04-22 07:20:05 |
| Message-ID: | 55374BA5.2060708@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 04/21/2015 11:38 PM, Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
>> Add missing installcheck target to pg_rewind's Makefile
>
> This patch seems a brick shy of a load, in that "make installcheck" in
> bin/pg_rewind leaves behind a bunch of junk in a tmp_check/ subdirectory.
> installcheck in any other src/bin/ subdirectory doesn't do that.
Ok, fixed.
It would actually be quite useful to leave tmp_check behind if the test
fails, for debugging purposes. Not just in pg_rewind, but in the other
subdirectories too. Another patch for another day..
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-04-22 07:44:35 | pgsql: Rename pg_replication_slot's new active_in to active_pid. |
| Previous Message | Heikki Linnakangas | 2015-04-22 07:20:04 | pgsql: Don't leave 'tmp_check' directory behind in pg_rewind regression |