| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix a typo in pg_rotate_logfile |
| Date: | 2024-02-12 20:39:06 |
| Message-ID: | 772E8FE1-B1F7-4472-A132-06498B9D6907@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 12 Feb 2024, at 21:32, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c
> - the hint message wrongly mentions that pg_logfile_rotate is part of
> the core; which is actually not. pg_logfile_rotate is an adminpack's
> 1.0 SQL function dropped in 2.0. The core defines pg_rotate_logfile
> SQL function instead, so use that. Here's a patch to fix the typo.
Nice catch! This needs to be backpatched all the way down to 12 as that
function wen't away a long time ago (it was marked as deprecated all the way
back in 9.1).
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2024-02-12 20:41:47 | Add test module for verifying backtrace functionality |
| Previous Message | Andres Freund | 2024-02-12 20:37:14 | Re: Popcount optimization using AVX512 |