Re: [COMMITTERS] pgsql: Give a better error message on invalid hostaddr option.

On 19/07/18 17:07, Robert Haas wrote:
> On Fri, Jun 9, 2017 at 6:06 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>> Give a better error message on invalid hostaddr option.
>>
>> If you accidentally pass a host name in the hostaddr option, e.g.
>> hostaddr=localhost, you get an error like:
>>
>> psql: could not translate host name "localhost" to address: Name or service not known
>>
>> That's a bit confusing, because it implies that we tried to look up
>> "localhost" in DNS, but it failed. To make it more clear that we tried to
>> parse "localhost" as a numeric network address, change the message to:
>>
>> psql: could not parse network address "localhost": Name or service not known
>
> This commit doesn't seem to deliver the behavior described in the
> commit message. Instead, I get:
>
> [rhaas pgsql]$ psql 'hostaddr=localhost'
> psql: could not parse network address "(null)": nodename nor servname
> provided, or not known
>
> Proposed patch attached.

Seems that I broke this shortly afterwards, by commit 7b02ba62e9.
Pushed, thanks!

- Heikki