Re: Regression (semi)fix for netbsd-mac68k

From: Rémi Zara <remi_zara(at)mac(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Regression (semi)fix for netbsd-mac68k
Date: 2004-12-22 23:37:36
Message-ID: 7648F4E0-5472-11D9-99CE-003065B81B34@mac.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Le 23 déc. 04, à 00:26, Tom Lane a écrit :

> =?ISO-8859-1?Q?R=E9mi_Zara?= <remi_zara(at)mac(dot)com> writes:
>> --- src/test/regress/resultmap.orig 2004-10-04
>> 16:42:47.000000000=20
>> +0200
>> +++ src/test/regress/resultmap 2004-12-22 23:27:51.000000000 +0100
>> @@ -3,6 +3,7 @@
>> float8/i.86-.*-freebsd[234]=float8-small-is-zero
>> float8/i.86-.*-openbsd=float8-small-is-zero
>> float8/i.86-.*-netbsd=float8-small-is-zero
>> +float8/m68k-.*-netbsd=float8-small-is-zero
>> float8/.*-qnx=float8-exp-three-digits
>> float8/i.86-pc-mingw32=float8-exp-three-digits-win32
>> float8/i.86-pc-cygwin=float8-small-is-zero
>
> Looks reasonable to me --- why do you call it only a "semi" fix

Because strtod really should underflow, so there seems to be a bug in
NetBSD's strtod.
So this is just accepting the bug, not correcting it :)

> I wonder whether we oughtn't remove the i.86- part from the patterns
> for the BSDen, ie, assume they will have this behavior on all hardware
> not just Intel.

From pgbuildfarm, it seems that openBSD sparc64 does not exhibit the
problem (it's not part of resultmap, and passes the float8 test).

Regards,

Rémi Zara
--
Rémi Zara
http://www.remi-zara.net/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2004-12-23 00:05:27 Re: RC2 and open issues
Previous Message Tom Lane 2004-12-22 23:26:32 Re: Regression (semi)fix for netbsd-mac68k