Re: Array detection in pg_dump

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Array detection in pg_dump
Date: 2009-08-06 23:15:23
Message-ID: 7639.1249600523@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Is there a reason we don't use pg_type.typcategory to detect arrays in
> Postgres 8.4? Right now I see this in pg_dump.c:

typcategory is user-assignable and thus not too reliable; furthermore
it wouldn't prove that the type is the array type for its typelem.
(Consider things like point and name --- there can be multiple types
with the same typelem, but only one is the real array type for that
typelem.) The typelem back-link check is much safer.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-08-06 23:19:27 Re: Array detection in pg_dump
Previous Message Ron Mayer 2009-08-06 23:14:33 Re: Table and Index compression