Re: Array detection in pg_dump

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Array detection in pg_dump
Date: 2009-08-06 23:19:42
Message-ID: 200908062319.n76NJgP28452@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Is there a reason we don't use pg_type.typcategory to detect arrays in
> > Postgres 8.4? Right now I see this in pg_dump.c:
>
> typcategory is user-assignable and thus not too reliable; furthermore
> it wouldn't prove that the type is the array type for its typelem.
> (Consider things like point and name --- there can be multiple types
> with the same typelem, but only one is the real array type for that
> typelem.) The typelem back-link check is much safer.

Thanks; I will use the pg_dump code in pg_migrator then.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-08-06 23:23:05 Re: Array detection in pg_dump
Previous Message Bruce Momjian 2009-08-06 23:19:27 Re: Array detection in pg_dump