| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Bruno Wolff III <bruno(at)wolff(dot)to>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS |
| Date: | 2017-06-23 00:35:55 |
| Message-ID: | 74102663-d4d0-57ef-ec26-9de49ed40a82@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2017/06/23 2:22, Alvaro Herrera wrote:
> Amit Langote wrote:
>> On 2017/06/21 11:02, Alvaro Herrera wrote:
>>> Bruno Wolff III wrote:
>>>> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF
>>>> NOT EXISTS. Given this is new, maybe there is a bug in the parser.
>>>
>>> You're absolutely right, and this is a bug in the parser -- I probably
>>> misplaced the IF NOT EXISTS clause while playing with Tomas' parser
>>> changes. Here's the fix. I'm a bit troubled that this change doesn't
>>> seem to affect any tests, so I'll add some before pushing.
>>
>> I posted the same patch but with a test:
>>
>> https://www.postgresql.org/message-id/38b7d52e-387a-0e47-7525-b8b654ca4bfb%40lab.ntt.co.jp
>
> Pushed.
Thanks, Alvaro.
Regards,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2017-06-23 01:39:57 | Re: BUG #14715: Constraint exclusion isn't used in function using language sql |
| Previous Message | Tom Lane | 2017-06-22 21:09:29 | Re: Bus error in formatting.c NUM_numpart_to_char (9.4.12, 9.6.3, sparc) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-06-23 00:37:11 | Re: Fix comment in xlog.c |
| Previous Message | Amit Langote | 2017-06-23 00:35:19 | Re: Redundant check of em_is_child |