Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Bruno Wolff III <bruno(at)wolff(dot)to>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS
Date: 2017-06-22 17:22:21
Message-ID: 20170622172221.qmudrzomu6iolznr@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Amit Langote wrote:
> On 2017/06/21 11:02, Alvaro Herrera wrote:
> > Bruno Wolff III wrote:
> >> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF
> >> NOT EXISTS. Given this is new, maybe there is a bug in the parser.
> >
> > You're absolutely right, and this is a bug in the parser -- I probably
> > misplaced the IF NOT EXISTS clause while playing with Tomas' parser
> > changes. Here's the fix. I'm a bit troubled that this change doesn't
> > seem to affect any tests, so I'll add some before pushing.
>
> I posted the same patch but with a test:
>
> https://www.postgresql.org/message-id/38b7d52e-387a-0e47-7525-b8b654ca4bfb%40lab.ntt.co.jp

Pushed.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2017-06-22 18:51:44 Re: Bus error in formatting.c NUM_numpart_to_char (9.4.12, 9.6.3, sparc)
Previous Message Tom Turelinckx 2017-06-22 16:59:20 Re: Bus error in formatting.c NUM_numpart_to_char (9.4.12, 9.6.3, sparc)

Browse pgsql-hackers by date

  From Date Subject
Next Message Shubham Barai 2017-06-22 17:32:03 Re: GSoC 2017 Proposal for predicate locking in hash index
Previous Message Peter Geoghegan 2017-06-22 17:08:34 Re: SQL MERGE patches for PostgreSQL Versions