Re: pg_upgrade check for invalid databases

> On 14 Oct 2024, at 18:57, Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> What might be acceptable would be to add an option that would make
> pg_upgrade more tolerant of problems in many areas, that is a lot more
> research and discussion.

I agree that the concept of having pg_upgrade perform (opt-in) skipping and/or
repairs of the old cluster warrants a larger discussion in its own thread.
There has been significant amount of energy spent recently to add structure to
the checks, any new feature should be properly designed for the get-go.

In the meantime, the OP has a good point that it's a tad silly that pg_upgrade
fails hard on invalid databases instead of detecting and reporting like how
other errors are handled. The attached adds this check and expands the report
wording to cover it.

--
Daniel Gustafsson