| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Subject: | Re: A bug in mapping attributes in ATExecAttachPartition() |
| Date: | 2017-07-12 01:47:24 |
| Message-ID: | 71bf5481-9577-79e8-6ef8-f6dd70d0bd3c@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/07/11 19:49, Ashutosh Bapat wrote:
> On Tue, Jul 4, 2017 at 9:51 AM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>
>>
>> Attached updated patches.
>
> There's an extra "we" in
> + * Note that attachRel's OID is in this list. If it's partitioned, we
> + * we don't need to schedule it to be scanned (would be a noop anyway
>
> And some portions of the comment before find_all_inheritors() in
> ATExecAttachPartition() look duplicated in portions of the code that
> check constraints on the table being attached and each of its leaf
> partition.
>
> Other than that the patches look good to me.
Thanks for the review. Patch updated taking care of the comments.
Regards,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Cope-with-differing-attnos-in-ATExecAttachPartition-.patch | text/plain | 11.3 KB |
| 0002-Teach-ATExecAttachPartition-to-skip-validation-in-mo.patch | text/plain | 11.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-07-12 01:56:22 | Re: Multi column range partition table |
| Previous Message | Amira Shawky | 2017-07-11 23:30:08 | Finding the min bounding box of an Index leaf page |