Re: ECPG cleanup and fix for clang compile-time problem

John Naylor <johncnaylorls(at)gmail(dot)com> writes:
> I started looking at the earlier cleanup patches.

Thanks for looking!

> 0001 seems straightforward. Note: It doesn't apply cleanly anymore,
> but does with 'patch'.

Odd, after rebasing it seems to have only line-number differences.

> + # Emit the target part of the rule.
> + # Note: the leading space is just to match
> + # the old, rather weird output logic.
> + $tstr = ' ' . $non_term_id . ':';
> + add_to_buffer('rules', $tstr);

> Removing the leading space (or making it two spaces) has no effect on
> the output -- does that get normalized elsewhere?

It does affect horizontal space in the generated preproc.y file,
which'd have no effect on the derived preproc.c file. I tweaked
the commit message to clarify that.

I adopted your other suggestions, no need to rehash them.

Here's a rebased but otherwise identical patchset. I also added
an 0007 that removes check_rules.pl as threatened.

regards, tom lane