Re: pgsql: Build ICU support by default.

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Davis <jdavis(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Build ICU support by default.
Date: 2023-04-19 04:23:43
Message-ID: 6d04d53841c445da4ab03be15dc4ea8369dc97ba.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, 2023-04-19 at 09:46 +0900, Michael Paquier wrote:
> As guaibasaurus is telling, this broke the generation of the
> distribution tarball:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2023-04-19%2000%3A20%3A03
>
> The problem is easy to reproduce: just run "make dist" from the top
> of
> the tree.  The fix is a bit more tricky, straight-forward once you
> know that ./INSTALL is generated from the contents of
> installation.sgml (learnt that the hard way), and is similar to
> 45aa88f where you should add a few extra rules to
> standalone-profile.xsl to replace the links by some text.  I guess
> that you could just replace both references with "the documentation"
> in this case, as the terms are specified in the paragraphs generated
> in the ./INSTALL, like the attached.

Ah, thank you.

> Do you mind if I apply the attached to fix the issue?

Please go ahead.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-04-19 05:00:27 pgsql: Fix generation of distribution tarball
Previous Message David Rowley 2023-04-19 01:51:07 pgsql: Fix various typos and incorrect/outdated name references