Re: Issues cross-compiling libpq 14.x to MacOS armv8

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Vincas Dargis <vindrg(at)gmail(dot)com>, pgsql-general <pgsql-general(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Issues cross-compiling libpq 14.x to MacOS armv8
Date: 2021-11-30 21:43:12
Message-ID: 6E5207E3-F529-4F6A-B380-724F24D1D40C@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

> On 30 Nov 2021, at 22:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I wrote:
>> It seems like a useful test when *not* cross compiling, which is most
>> of the time. I'd just wrap that bit in
>> if test "$cross_compiling" = no; then
>
> Or actually, since we should print something, it looks like this will do:

+1, looks reasonable.

> +elif test x"$cross_compiling" = x"yes"; then

I noticed that we test without the x"foo" = x"yes" construction for zic (line
1135), should we change that while at it and be consistent for all
$cross_compiling uses?

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2021-11-30 22:08:10 Re: Issues cross-compiling libpq 14.x to MacOS armv8
Previous Message Tom Lane 2021-11-30 21:33:14 Re: Issues cross-compiling libpq 14.x to MacOS armv8