| From: | Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
|---|---|
| To: | "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com> |
| Cc: | "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor inheritance/check bug: Inconsistent behavior |
| Date: | 2012-09-14 14:04:51 |
| Message-ID: | 6C0B27F7206C9E4CA54AE035729E9C38285326B8@szxeml509-mbs |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote:
On Tue, Aug 28, 2012 at 6:40 AM, Amit Kapila <amit(dot)kapila(at)huawei(dot)com> wrote:
>> AFAICT during Update also, it doesn't contain useful. The only chance it
>> would have contain something useful is when it goes for EvalPlanQual and
>> then again comes to check for constraints. However these attributes get
>> filled in heap_update much later.
>
>> So now should the fix be that it returns an error for system column
>> reference except for OID case?
> +1.
1. I think in this scenario the error for system column except for tableOID should be thrown at Create/Alter time.
2. After setting OID in ExecInsert/ExecUpdate may be setting of same inside heap functions can be removed.
But for now I have kept them as it is.
Please find the Patch for bug-fix.
If this is okay, I shall send you the test cases for same.
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| system_col_constr.patch | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2012-09-14 14:13:39 | Re: contrib translations |
| Previous Message | Alvaro Herrera | 2012-09-14 13:59:45 | Re: contrib translations |