Re: vcbuild bison check

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: vcbuild bison check
Date: 2006-10-04 07:30:30
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA3577C@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> >>> Attached patch adds a version check for bison when running the
> vc++
> >>> build.
> >>
> >> Shouldn't it be looking for 2.1 as well?
>
> > 2.1 is the broken one.
>
> Exactly. So we should reject it.

We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1.

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2006-10-04 07:35:53 Re: [HACKERS] cvsweb.cgi missing colors
Previous Message Pavel Stehule 2006-10-04 06:42:53 PL/pgSQL Todo, better information in errcontext from plpgsql

Browse pgsql-patches by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-10-04 09:46:35 Re: scripts/common.c minor memory leak
Previous Message Tom Lane 2006-10-04 05:11:18 Re: putting CHECK_FOR_INTERRUPTS in qsort_comparetup()