| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Magnus Hagander <mha(at)sollentuna(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: vcbuild bison check |
| Date: | 2006-10-04 10:12:29 |
| Message-ID: | 200610041012.k94ACTA29139@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Magnus Hagander wrote:
> > >>> Attached patch adds a version check for bison when running the
> > vc++
> > >>> build.
> > >>
> > >> Shouldn't it be looking for 2.1 as well?
> >
> > > 2.1 is the broken one.
> >
> > Exactly. So we should reject it.
>
> We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1.
I think Tom's point is that we should reject only 2.1. Isn't that the
only version that fails?
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-10-04 10:15:31 | Re: pgindent has been run |
| Previous Message | Michael Meskes | 2006-10-04 10:12:27 | Re: buildfarm failures in ECPG-Check |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zdenek Kotala | 2006-10-04 12:39:28 | Re: [HACKERS] DOC: catalog.sgml |
| Previous Message | Martijn van Oosterhout | 2006-10-04 09:46:35 | Re: scripts/common.c minor memory leak |