Re: Adminpack build fix

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Adminpack build fix
Date: 2006-10-19 17:44:42
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC8F@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > Attached patch removes a couple of extern definitions from
> adminpack,
> > replacing some of them with a #include. (Cam eup with this
> because we
> > got a duplicate definition of DataDir when building with
> Visual C++).
>
> That isn't going to work unless we put DLLIMPORT into the
> main headers.
> The reason for redeclaring these in the contrib files is to
> get DLLIMPORT onto them...

Interedting - it builds on MSVC without it :-O

Anyway. That certainly explains why MSVC is complaining - it's getting
completely different definitions of these variables from the header and
from the actual file.

What do you think about simply adding DLLIMPORT to the variables in the
main header?

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-10-19 17:47:21 Re: Adminpack build fix
Previous Message Magnus Hagander 2006-10-19 17:43:10 Re: [PATCHES] Contrib Makefiles

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-10-19 17:47:21 Re: Adminpack build fix
Previous Message Magnus Hagander 2006-10-19 17:43:10 Re: [PATCHES] Contrib Makefiles