Re: Adminpack build fix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Adminpack build fix
Date: 2006-10-19 17:38:58
Message-ID: 29296.1161279538@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Attached patch removes a couple of extern definitions from adminpack,
> replacing some of them with a #include. (Cam eup with this because we
> got a duplicate definition of DataDir when building with Visual C++).

That isn't going to work unless we put DLLIMPORT into the main headers.
The reason for redeclaring these in the contrib files is to get
DLLIMPORT onto them...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-10-19 17:41:50 Re: Contrib Makefiles
Previous Message Magnus Hagander 2006-10-19 17:27:27 Adminpack build fix

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-10-19 17:41:50 Re: Contrib Makefiles
Previous Message Magnus Hagander 2006-10-19 17:27:27 Adminpack build fix