Re: [HACKERS] Bad bug in fopen() wrapper code

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>, "Claudio Natoli" <claudio(dot)natoli(at)memetrics(dot)com>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Bad bug in fopen() wrapper code
Date: 2006-10-03 19:08:23
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC16@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > > > I agree that this code is both wrong and unreadable
> (although in
> > > > practice the _setmode will probably never fail, which
> is why our
> > > > attention hasn't been drawn to it). Is someone going
> to submit a
> > > > patch? I'm hesitant to change the code myself since
> I'm not in a
> > > > position to test it.
> > >
> > > I can look at fixing that. Is it something we want to do
> for 8.2, or
> > > wait until 8.3? If there's a hidden bug, I guess 8.2?
> >
> > Magnus, is this the right fix?
>
> Claudio sent me some small updates to the patch; updated
> version attached.

Tested, passes all regression tests on MingW.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2006-10-03 19:23:05 Re: Another idea for dealing with cmin/cmax
Previous Message Magnus Hagander 2006-10-03 19:07:12 MSVC build broken (again)

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2006-10-03 19:36:17 vcbuild bison check
Previous Message Magnus Hagander 2006-10-03 19:07:12 MSVC build broken (again)