MSVC build broken (again)

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: <pgsql-patches(at)postgresql(dot)org>
Subject: MSVC build broken (again)
Date: 2006-10-03 19:07:12
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC15@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

The code around errcode is definitly messy. In CVS now, it actually
renames *our* errcode() function to __msvc_errcode, and exports this
from postgres.exe. This is definitly very borken.

The check for _MSC_VER > 1400 won't come true until Microsoft releases
the next verison of Visual Studio - VS2005 is 1400, not >1400.

Attached patch fixes this. Tested on MSVC and on Mingw.

//Magnus

Attachment Content-Type Size
vcbuild.diff application/octet-stream 1.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2006-10-03 19:08:23 Re: [HACKERS] Bad bug in fopen() wrapper code
Previous Message Magnus Hagander 2006-10-03 19:04:31 Re: src/tools/msvc usage instructions

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2006-10-03 19:08:23 Re: [HACKERS] Bad bug in fopen() wrapper code
Previous Message Sergey E. Koposov 2006-10-03 16:21:30 Re: 7.4, 8.0 branches @ itanium2 & icc